Fix full-page screenshots in some circumstances.#43
Conversation
Even adding just <!DOCTYPE html> to long_page.erb will kick Chrome into a different rendering mode but setting html's height to 100% seems to be the more reliable method.
|
So I just looked at an actual image from this and whilst the size of the output image is correct "below the fold" is blank/white. I can't see that anything else is incorrect according to https://github.com/ChromeDevTools/devtools-protocol/blob/be5771fecba801dc93ab2a8e6260b2249270a7e8/types/protocol.d.ts#L9844-L9861 and https://github.com/ChromeDevTools/devtools-protocol/blob/be5771fecba801dc93ab2a8e6260b2249270a7e8/types/protocol.d.ts#L9713-L9734? |
|
Sorry for the delay in this - I've been really busy recently. I plan to update apparition to meet recent Capybara changes, but will hopefully get to this tomorrow |
|
Hmmm -- I see the issue -- not really sure how to fix, or if it is fixable - will require more research |
|
Yes I agree though oddly it doesn't occur with Ferrum - they even fixed the same issue recently rubycdp/ferrum#51 |
2 participants
Even adding just
<!DOCTYPE html>to long_page.erb will kick Chrome into a different rendering mode but setting html's height to 100% seems to be the more reliable method.Fixes #39.